How to set HAL JPEG register callbacks

ladislas · February 23, 2021, 3:13pm

For our project, we need to use the HAL confg USE_HAL_JPEG_REGISTER_CALLBACKS available here:

ARMmbed/mbed-os/blob/master/targets/TARGET_STM/TARGET_STM32F7/STM32Cube_FW/stm32f7xx_hal_conf.h#L166


#define  USE_HAL_DCMI_REGISTER_CALLBACKS        0U /* DCMI register callback disabled      */
#define  USE_HAL_DFSDM_REGISTER_CALLBACKS       0U /* DFSDM register callback disabled     */
#define  USE_HAL_DMA2D_REGISTER_CALLBACKS       0U /* DMA2D register callback disabled     */
#define  USE_HAL_DSI_REGISTER_CALLBACKS         0U /* DSI register callback disabled       */
#define  USE_HAL_ETH_REGISTER_CALLBACKS         0U /* ETH register callback disabled       */
#define  USE_HAL_HASH_REGISTER_CALLBACKS        0U /* HASH register callback disabled      */
#define  USE_HAL_HCD_REGISTER_CALLBACKS         0U /* HCD register callback disabled       */
#define  USE_HAL_I2C_REGISTER_CALLBACKS         0U /* I2C register callback disabled       */
#define  USE_HAL_I2S_REGISTER_CALLBACKS         0U /* I2S register callback disabled       */
#define  USE_HAL_IRDA_REGISTER_CALLBACKS        0U /* IRDA register callback disabled      */
#define  USE_HAL_JPEG_REGISTER_CALLBACKS        0U /* JPEG register callback disabled      */
#define  USE_HAL_LPTIM_REGISTER_CALLBACKS       0U /* LPTIM register callback disabled     */
#define  USE_HAL_LTDC_REGISTER_CALLBACKS        0U /* LTDC register callback disabled      */
#define  USE_HAL_MDIOS_REGISTER_CALLBACKS       0U /* MDIOS register callback disabled     */
#define  USE_HAL_MMC_REGISTER_CALLBACKS         0U /* MMC register callback disabled       */
#define  USE_HAL_NAND_REGISTER_CALLBACKS        0U /* NAND register callback disabled      */
#define  USE_HAL_NOR_REGISTER_CALLBACKS         0U /* NOR register callback disabled       */
#define  USE_HAL_PCD_REGISTER_CALLBACKS         0U /* PCD register callback disabled       */
#define  USE_HAL_QSPI_REGISTER_CALLBACKS        0U /* QSPI register callback disabled      */
#define  USE_HAL_RNG_REGISTER_CALLBACKS         0U /* RNG register callback disabled       */
#define  USE_HAL_RTC_REGISTER_CALLBACKS         0U /* RTC register callback disabled       */

It is set to 0 and I don’t know how we can set it to one without modifying mbed-os’ files.

Do you have any idea? I can make a PR with a solution similar to this one:

github.com

ARMmbed/mbed-os/blob/8340ea2d2b39d12a5220928b30c4b3dc90fd5dff/targets/TARGET_STM/TARGET_STM32F7/STM32Cube_FW/stm32f7xx_hal_conf.h#L93-L95


#if !defined  (HSE_VALUE) 
  #define HSE_VALUE    8000000U /*!< Value of the External oscillator in Hz */
#endif /* HSE_VALUE */

Let me know

Best,
– Ladislas

jeromecoutant · February 23, 2021, 4:32pm

Hi
To be honest I have never used CALLBACKS…
About your issue, I think your proposition is valid.
We should even make a script that updates all the USE_HAL_xxx_REGISTER_CALLBACKS…

ladislas · February 23, 2021, 4:50pm

You never got the chance? Or you have a different solution?

It turns out that interfacing the HAL code with C++ is not easy… And I’m not talking about unit testing all that…

ladislas · February 24, 2021, 9:37am

We ended up using a global object but that’s okay in our case. Funny enough we can now pass lambdas to the function which is quite nice

	HAL_JPEG_RegisterInfoReadyCallback(corejpeg.getJpegHandle(), [](JPEG_HandleTypeDef *hjpeg, JPEG_ConfTypeDef *info) {
		corejpeg.onInfoReadyCallback(hjpeg, info);
	});

	HAL_JPEG_RegisterGetDataCallback(corejpeg.getJpegHandle(), [](JPEG_HandleTypeDef *hjpeg, uint32_t size) {
		corejpeg.onDataAvailableCallback(hjpeg, size);
	});

	HAL_JPEG_RegisterDataReadyCallback(corejpeg.getJpegHandle(),
									   [](JPEG_HandleTypeDef *hjpeg, uint8_t *pDataOut, uint32_t size) {
										   corejpeg.onDataReadyCallback(hjpeg, pDataOut, size);
									   });

	HAL_JPEG_RegisterCallback(corejpeg.getJpegHandle(), HAL_JPEG_DECODE_CPLT_CB_ID,
							  [](JPEG_HandleTypeDef *hjpeg) { corejpeg.onDecodeCompleteCallback(hjpeg); });

	HAL_JPEG_RegisterCallback(corejpeg.getJpegHandle(), HAL_JPEG_ERROR_CB_ID,
							  [](JPEG_HandleTypeDef *hjpeg) { corejpeg.onErrorCallback(hjpeg); });

MultipleMonomials · February 25, 2021, 3:02am

Woah, that works? I didn’t realize you could do that. It must be only for non-capturing lambdas though right?

ladislas · February 25, 2021, 8:46am

Sadly yes, but that’s better than nothing!

ladislas · February 25, 2021, 2:57pm

I’ve made a PR : STM32F7 - Add if defined check for USE_HAL_XXX_REGISTER_CALLBACKS by ladislas · Pull Request #14351 · ARMmbed/mbed-os · GitHub